adding clrgc variant with regions enabled #89129
Conversation
|
Tagging subscribers to this area: @dotnet/gc Issue Detailswe already ship standalone clrgc.dll with segments. This adds another clrgcr.dll with regions enabled.
|
| @@ -104,6 +104,16 @@ list(APPEND GC_SOURCES ${GC_HEADERS}) | |||
|
|
|||
| convert_to_absolute_path(GC_SOURCES ${GC_SOURCES}) | |||
|
|
|||
| # clrgcr is build with standalone+regions | |||
| if (CLR_CMAKE_TARGET_ARCH_ARM64 OR CLR_CMAKE_TARGET_ARCH_AMD64) | |||
There was a problem hiding this comment.
this builds clrgcr.dll (and libclrgcr.so) on 64 bit platforms. We could change naming if required.
There was a problem hiding this comment.
NIT: for the sake of readability, would it be better to change the name to: clrgc_regions?
There was a problem hiding this comment.
didnt want to name it as regions since longer term it might be for a different feature. Perhaps something like experimental or something. Maybe rename it clrgce for experimental ?
There was a problem hiding this comment.
yeah that works, will rename.
|
CI failures look unrelated but will take a closer look. |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Ci is now green. Please review, we can discuss naming, but anything we come up with would most likely require changing. |
* adding clrgc variant with regions enabled * only build regions for 64 bit platforms * rename to clrgcexp for experimental
ghost
locked as resolved and limited conversation to collaborators
we already ship standalone clrgc.dll with segments. This adds another clrgcr.dll with regions enabled.